fix: show path in external_directory permission prompt#7272
Closed
jamesbornholt wants to merge 1 commit intoanomalyco:devfrom
Closed
fix: show path in external_directory permission prompt#7272jamesbornholt wants to merge 1 commit intoanomalyco:devfrom
jamesbornholt wants to merge 1 commit intoanomalyco:devfrom
Conversation
- Update bash tool to ask for each external directory individually (consistent with read/edit/patch tools) - Populate metadata.parentDir in bash tool's external_directory request - Use metadata.parentDir in permission UI instead of non-existent input().path - Display absolute path for external directories instead of relative
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one PR that is closely related to PR #7272: Related PR:
This PR is related as both address improving the clarity and information displayed in external_directory permission prompts, though they may be targeting different tools (write tool vs bash tool). |
Author
|
This was fixed in 96ae592 (thank you!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, external_directory permissions prompts, at least for read tools, didn't show a path at all. You could figure it out by seeing which tool usages were pending, but that was annoying especially if it was a different session triggering the prompt. The "always allow" confirmation screen did include the path though.